[Webkit-unassigned] [Bug 49151] [Chromium] REGRESSION(71474?) failing webkit tests on chromium canaries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49151





--- Comment #6 from Dirk Pranke <dpranke at chromium.org>  2010-11-08 15:35:10 PST ---
(In reply to comment #5)
> (From update of attachment 73290 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73290&action=review
> 
> > WebKitTools/ChangeLog:31
> > +2010-11-07  Fumitoshi Ukai  <ukai at chromium.org>
> > +
> > +        Unreviewed, rolling out r71475.
> 
> I don't think you meant to move Ukai's entry.
> 

No, I didn't. I caught the other one, but not this one. I'll add it back in. I'm not sure why I didn't notice it in the diff.

> > WebKitTools/Scripts/webkitpy/common/system/filesystem_mock.py:55
> > +    def isdir(self, path):
> > +        # FIXME: Implement :)
> > +        raise NotImplementedError
> 
> I'm still not a big fan of these stubs. :)
> 

Then, for you, I'll remove them :)

> > WebKitTools/Scripts/webkitpy/common/system/filesystem_mock.py:77
> > +                exception = IOError()
> > +                exception.errno = errno.ENOENT
> > +                exception.filename = path
> > +                exception.strerror = "No such file or directory"
> 
> I bet there is a constructor...
> 

Yeah, sort of. It appears to be relatively undocumented, but is obvious enough how to use it. Added.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.