[Webkit-unassigned] [Bug 49151] [Chromium] REGRESSION(71474?) failing webkit tests on chromium canaries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49151


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73290|review?                     |review+
               Flag|                            |




--- Comment #5 from Eric Seidel <eric at webkit.org>  2010-11-08 15:06:43 PST ---
(From update of attachment 73290)
View in context: https://bugs.webkit.org/attachment.cgi?id=73290&action=review

> WebKitTools/ChangeLog:31
> +2010-11-07  Fumitoshi Ukai  <ukai at chromium.org>
> +
> +        Unreviewed, rolling out r71475.

I don't think you meant to move Ukai's entry.

> WebKitTools/Scripts/webkitpy/common/system/filesystem_mock.py:55
> +    def isdir(self, path):
> +        # FIXME: Implement :)
> +        raise NotImplementedError

I'm still not a big fan of these stubs. :)

> WebKitTools/Scripts/webkitpy/common/system/filesystem_mock.py:77
> +                exception = IOError()
> +                exception.errno = errno.ENOENT
> +                exception.filename = path
> +                exception.strerror = "No such file or directory"

I bet there is a constructor...

> WebKitTools/Scripts/webkitpy/layout_tests/port/config.py:126
> +        # Note: this code somewhat duplicates the code in
> +        # scm.find_checkout_root(). However, that code only works if the top
> +        # of the SCM repository also matches the top of the WebKit tree. The
> +        # Chromium ports, for example, only check out subdirectories like
> +        # WebKitTools/Scripts, and so we still have to do additional work
> +        # to find the top of the tree.

I suspect lots of other pieces of webkitpy break for chromium too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.