[Webkit-unassigned] [Bug 49018] [GTK] response.isNull() assert when using directory file URI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49018





--- Comment #7 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>  2010-11-08 13:01:11 PST ---
(In reply to comment #6)
> Nice catch!. Some comments to your patch
> 
> > WebCore/platform/network/soup/ResourceHandleSoup.cpp:-694
> > -    if (equalIgnoringCase(protocol, "http") || equalIgnoringCase(protocol, "https")) {
> 
> Although not directly related to the bug I think you can indeed include style fixes.

Ok, but I'll be careful next time, didn't notice I did that.

> 
> > WebCore/platform/network/soup/ResourceHandleSoup.cpp:-699
> > -    if (equalIgnoringCase(protocol, "file") || equalIgnoringCase(protocol, "ftp") || equalIgnoringCase(protocol, "ftps")) {
> 
> If I am not wrong, this has nothing to do with the bug so, I guess you either should attach another patch or maybe a different bug, Martin?

I'll let Martin reply, normally I would split this up in a git branch, but WebKit process with ChangeLog is such a *** that I prefer keep related one liner together.

> 
> > WebCore/platform/network/soup/ResourceHandleSoup.cpp:793
> >      GOwnPtr<GError> error;
> 
> You're indeed right, we're not notifying about the didReceiveResponse for directories but:
> 
> 1) why don't you just remove the condition in line 534 then?, and

That would mean calling didReceiveResponse multiple time in the case of HTTP. Also there was discussion about Soup future where FTP would fire callbacks that triggers didReceiveResponse too, and potentially other protocols. Checking if a response was send right before passing the first buffer seems to be the most generic solution at the moment.

> 2) in order to keep the consistency of the new design for ResourceHandleSoup, the didReceiveResponse should be called before any read, so it's better to keep the check in sendRequestCallback.

That's pretty much explained in 1), but one addition is that currently didReceiveResponse() is called during the first read and not before.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.