[Webkit-unassigned] [Bug 48985] [Qt][WK2] Left over files and shared memory segments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48985


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72940|review?                     |review+
               Flag|                            |




--- Comment #6 from Andreas Kling <kling at webkit.org>  2010-11-04 08:42:01 PST ---
(From update of attachment 72940)
View in context: https://bugs.webkit.org/attachment.cgi?id=72940&action=review

r=me, three small things:

> WebKit2/Shared/qt/CrashHandler.cpp:30
> +#include <QCoreApplication>

Is this include needed?

> WebKit2/Shared/qt/CrashHandler.h:34
> +#include <QCoreApplication>

Is this include needed?

> WebKit2/Shared/qt/CrashHandler.h:74
> +#endif // CleanupHandler_h

#endif // CrashHandler_h

> WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:119
> +    // Do not leave socket files on the disk even on crash!
> +    CrashHandler::instance()->markForDeletionOnCrash(this);

This call is missing a corresponding didDelete() in ~ProcessLauncherHelper()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.