[Webkit-unassigned] [Bug 48985] [Qt][WK2] Left over files and shared memory segments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48985





--- Comment #7 from Balazs Kelemen <kbalazs at webkit.org>  2010-11-04 09:33:57 PST ---
(In reply to comment #6)
> (From update of attachment 72940 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72940&action=review
> 
> r=me, three small things:
> 
> > WebKit2/Shared/qt/CrashHandler.cpp:30
> > +#include <QCoreApplication>
> 
> Is this include needed?
No
> 
> > WebKit2/Shared/qt/CrashHandler.h:34
> > +#include <QCoreApplication>
> 
> Is this include needed?
No :)
> 
> > WebKit2/Shared/qt/CrashHandler.h:74
> > +#endif // CleanupHandler_h
> 
> #endif // CrashHandler_h
> 
> > WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:119
> > +    // Do not leave socket files on the disk even on crash!
> > +    CrashHandler::instance()->markForDeletionOnCrash(this);
> 
> This call is missing a corresponding didDelete() in ~ProcessLauncherHelper()
I omit that because ProcessLauncherHelper lives as long as the process, however
we can CRASH even after ~ProcessLauncherHelper() is called so you are right.

I will fix the issues (and do final a smoke test) before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.