[Webkit-unassigned] [Bug 48614] webkitpy.layout_tests.run_webkit_tests_unittest.MainTest gets wedged on Windows XP/Cygwin 1.5/Python 2.5.2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48614





--- Comment #7 from Adam Roben (aroben) <aroben at apple.com>  2010-11-01 15:29:56 PST ---
(In reply to comment #6)
> (From update of attachment 72555 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72555&action=review
> 
> change looks reasonable to me. I assume this is backported from code in 3.2 or other parts of unittest?

Yes, backported from 3.1+.

> >> WebKitTools/Scripts/webkitpy/test/skip.py:39
> >> +    return klass
> > 
> > I'm not sure of the best way to test skip_if. Any suggestions?
> 
> I would create a dummy class, e.g.:
> 
> TestSkipFixture(object):
>      def test_foo(self):
>          pass
> 
> and then call skip_if(TestSkipFixture, True), then call test_foo() and use outputcapture to ensure the messages get logged. And vice-versa for skip_if(TestSkipFixture, False).

Thanks for the suggestion. Unfortunately outputcapture doesn't seem to be capturing the output from skip_if's logger. Any ideas why that might be happening? Maybe the logger buffers its input?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.