[Webkit-unassigned] [Bug 48614] webkitpy.layout_tests.run_webkit_tests_unittest.MainTest gets wedged on Windows XP/Cygwin 1.5/Python 2.5.2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48614





--- Comment #6 from Dirk Pranke <dpranke at chromium.org>  2010-11-01 14:26:24 PST ---
(From update of attachment 72555)
View in context: https://bugs.webkit.org/attachment.cgi?id=72555&action=review

change looks reasonable to me. I assume this is backported from code in 3.2 or other parts of unittest?

Sadly, I'm not a reviewer so you'll still need someone else to r+ this.

>> WebKitTools/Scripts/webkitpy/test/skip.py:39
>> +    return klass
> 
> I'm not sure of the best way to test skip_if. Any suggestions?

I would create a dummy class, e.g.:

TestSkipFixture(object):
     def test_foo(self):
         pass

and then call skip_if(TestSkipFixture, True), then call test_foo() and use outputcapture to ensure the messages get logged. And vice-versa for skip_if(TestSkipFixture, False).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.