[Webkit-unassigned] [Bug 48516] GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48516





--- Comment #35 from Nikolas Zimmermann <zimmermann at kde.org>  2010-11-01 13:07:57 PST ---
(In reply to comment #34)
> (In reply to comment #33)
> > (In reply to comment #32)
> > > Created an attachment (id=72503)
 --> (https://bugs.webkit.org/attachment.cgi?id=72503&action=review) [details] [details] [details]
> > > Proposed patch v2
> > > 
> > > Rebased and updated patch.
> > > 
> > > beginPath() -> deprecatedBeginPath()
> > > addPath() -> deprecatedAddPath()
> > > 
> > > Layout test results on Snow Leopard (I don't think any of the failures are legit):
> > > http://chaos.troll.no/~kling/48516/layout-test-results/results.html
> > 
> > Has this patch been performance tested?
> > 
> > I am slightly concerned by this patch as it seems to not gain us anything other than move from being more like one API to being more like another.  I certainly think we need a very good reason before making such a dramatic change.

We should get some numbers, agreed. But certainly calling one method instead of three is better.

context->beginPath();
context->addPath(path);
context->fillPath()

vs. context->fillPath(path).

Dirk already said that we also save memory, as the current path concept is not giving us any benefits.
And I don't think this patch is anything but dramatic, it's rather simple.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.