[Webkit-unassigned] [Bug 48516] GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 1 12:01:03 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=48516





--- Comment #34 from Dirk Schulze <krit at webkit.org>  2010-11-01 12:01:02 PST ---
(In reply to comment #33)
> (In reply to comment #32)
> > Created an attachment (id=72503)
 --> (https://bugs.webkit.org/attachment.cgi?id=72503&action=review) [details] [details]
> > Proposed patch v2
> > 
> > Rebased and updated patch.
> > 
> > beginPath() -> deprecatedBeginPath()
> > addPath() -> deprecatedAddPath()
> > 
> > Layout test results on Snow Leopard (I don't think any of the failures are legit):
> > http://chaos.troll.no/~kling/48516/layout-test-results/results.html
> 
> Has this patch been performance tested?
> 
> I am slightly concerned by this patch as it seems to not gain us anything other than move from being more like one API to being more like another.  I certainly think we need a very good reason before making such a dramatic change.

Many posters above already talked about the benefits. The main benefit in my eyes is that most platforms don't support the currenPath concept of CG. Storing the currentPath is a performance and memory issue on those platforms. This is a very good reason to move to a new concept for me.
On the other hand, I don't see performance issues for CG, beside the one I blamed on my first review. If there are performance problems, they need to be fixed before this patch gets landed of course. Please help us to find them.
Is there a performance test on webkit for graphics?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list