[Webkit-unassigned] [Bug 39146] [Qt] Pass all web notification layout tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39146





--- Comment #26 from Yael <yael.aharon at nokia.com>  2010-05-31 18:59:35 PST ---
(In reply to comment #25)
> (From update of attachment 57231 [details])
> 
> This part _continues_ to look wrong :-(
> 
> Clearing the window object has nothing to do with notifications, and this function is called _per frame_ where as the notifications are cleared per page. So if one sub-frame reloads it clears the notifications for the entire page.

I have a new patch that changes the behavior drastically. Notifications will no longer be cleared with the window object, but with a timer. (QSystemTrayIcon does not emit a signal when it closes). Also, NotificationPresenter should be one per process, and not per page.

The problem is that it is 40K, and I do not know how to cut it into smaller chunks, without causing tests to fail.

What would be the best way for me to explain that patch? IRC? comments in code? please advice :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.