[Webkit-unassigned] [Bug 39146] [Qt] Pass all web notification layout tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39146





--- Comment #25 from Simon Hausmann <hausmann at webkit.org>  2010-05-30 23:06:50 PST ---
(From update of attachment 57231)

> Index: WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
> ===================================================================
> --- WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp	(revision 60296)
> +++ WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp	(working copy)
> @@ -51,6 +51,7 @@
>  #include "HTMLFormElement.h"
>  #include "HTMLPlugInElement.h"
>  #include "HTTPParsers.h"
> +#include "NotificationPresenterClientQt.h"
>  #include "NotImplemented.h"
>  #include "QNetworkReplyHandler.h"
>  #include "ResourceHandleInternal.h"
> @@ -638,8 +639,12 @@ void FrameLoaderClientQt::dispatchDidCle
>      if (world != mainThreadNormalWorld())
>          return;
>  
> -    if (m_webFrame)
> +    if (m_webFrame) {
>          emit m_webFrame->javaScriptWindowObjectCleared();
> +#if ENABLE(NOTIFICATIONS)
> +        m_webFrame->page()->d->notificationPresenterClient->clearNotificationsList();
> +#endif
> +    }

This part _continues_ to look wrong :-(

Clearing the window object has nothing to do with notifications, and this function is called _per frame_ where as the notifications are cleared per page. So if one sub-frame reloads it clears the notifications for the entire page.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.