[Webkit-unassigned] [Bug 39957] Chromium: save inspector settings as dictionary, not as string.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39957





--- Comment #3 from Pavel Podivilov <podivilov at chromium.org>  2010-05-31 10:00:09 PST ---
> WebKit/chromium/src/InspectorClientImpl.cpp:96
>  +      m_inspectedWebView->inspectorSetting(key, &string);
> So it did not compile for you with simply putting 'value' as a second argument?

Yep, it did not.

> 
> 
> WebKit/chromium/src/WebViewImpl.h:491
>  +      typedef HashMap<WebCore::String, WebCore::String> SettingsMap;
> WebKit should operate WebKit strings. I know it was wrong, but it may be a good time to fix it.

We need a map here, because InspectorClient will ask for inspector settings by key.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.