[Webkit-unassigned] [Bug 39957] Chromium: save inspector settings as dictionary, not as string.

Mon May 31 09:14:49 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=39957

Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57472|                            |review+
               Flag|                            |

--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2010-05-31 09:14:49 PST ---
(From update of attachment 57472)
r+ with nits.

WebKit/chromium/src/InspectorClientImpl.cpp:96
 +      m_inspectedWebView->inspectorSetting(key, &string);
So it did not compile for you with simply putting 'value' as a second argument?

WebKit/chromium/src/WebViewImpl.h:491
 +      typedef HashMap<WebCore::String, WebCore::String> SettingsMap;
WebKit should operate WebKit strings. I know it was wrong, but it may be a good time to fix it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.