[Webkit-unassigned] [Bug 39429] Add DOMStringList idl, needed for IndexedDB and for HTML5 drag & drop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39429





--- Comment #10 from Jeremy Orlow <jorlow at chromium.org>  2010-05-24 02:44:56 PST ---
(In reply to comment #9)
> (From update of attachment 56731 [details])
> +bool DOMStringList::contains(const String& str) const
> 
> There's no need to abbreviate.
> 
> +// FIXME: Some consumers of this class may benefit from lazily fetching items rather
> +//        than creating the list statically as is currently the only option.  If so,
> +//        you may want to take a look at the original implementation which was removed
> +//        in r44943 and make this class an interface in a similar way.
> 
> I don't think there was anything particularly high-tech in r44943 to quote it, it's just as easy to write from scratch :). The FIXME should be shorter.

done


> +    ] DOMStringList {
> +        readonly attribute unsigned long length;
> +        DOMString item(in [IsIndex] unsigned long index);
> +    };
> 
> Please add contains().

Oops!


> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> 
> There is no "Apple Computer" any more, and we use a two-clause license - please see <http://webkit.org/coding/bsd-license.html>.

Changed...but is there anything wrong with using a 3 clause license or using the ones with apple computer?  Because I just copied this from another file.  And it seems as though there's a lot with these mistakes.  And, as far as I can tell, every mention (when submitting a patch and what I remember of the contributors agreement) only mentions "BSD License" not a specific one or one with a particular number of clauses.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.