[Webkit-unassigned] [Bug 39429] Add DOMStringList idl, needed for IndexedDB and for HTML5 drag & drop

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 21 12:32:46 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39429


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56731|review?                     |review+
               Flag|                            |




--- Comment #9 from Alexey Proskuryakov <ap at webkit.org>  2010-05-21 12:32:46 PST ---
(From update of attachment 56731)
+bool DOMStringList::contains(const String& str) const

There's no need to abbreviate.

+// FIXME: Some consumers of this class may benefit from lazily fetching items rather
+//        than creating the list statically as is currently the only option.  If so,
+//        you may want to take a look at the original implementation which was removed
+//        in r44943 and make this class an interface in a similar way.

I don't think there was anything particularly high-tech in r44943 to quote it, it's just as easy to write from scratch :). The FIXME should be shorter.

+    ] DOMStringList {
+        readonly attribute unsigned long length;
+        DOMString item(in [IsIndex] unsigned long index);
+    };

Please add contains().

+ * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of

There is no "Apple Computer" any more, and we use a two-clause license - please see <http://webkit.org/coding/bsd-license.html>.

r=me with these fixes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list