[Webkit-unassigned] [Bug 39479] Add DeviceOrientation and DeviceOrientationClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39479





--- Comment #11 from Steve Block <steveblock at google.com>  2010-05-21 07:09:18 PST ---
(In reply to comment #10)
> (From update of attachment 56705 [details])
> WebCore/ChangeLog:14
>  +          No new tests are possible at this time.
> Please explain why.  And promise to land them soon.  :-)
Done

> WebCore/dom/DeviceOrientation.cpp:47
>  +      UNUSED_PARAM(alpha);
> You may need to include wtf/UnusedParam.h
Done

> WebKit/chromium/src/WebViewImpl.cpp:264
>  +                          0));
> I don't know why these are split across multiple lines like this, but it doesn't match WebKit style...so mind putting these all on one line?
Done

> WebKit/mac/WebView/WebView.mm:666
>  +      _private->page = new Page(new WebChromeClient(self), new WebContextMenuClient(self), new WebEditorClient(self), new WebDragClient(self), new WebInspectorClient(self), new WebPluginHalterClient(self), geolocationControllerClient, deviceOrientationClient);
> Where is deviceOrientationClient defined?
On the line above. Since all the other params are named, I thought it best to do it like this rather than use 0. What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.