[Webkit-unassigned] [Bug 39479] Add DeviceOrientation and DeviceOrientationClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39479


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56705|review?                     |review-
               Flag|                            |




--- Comment #10 from Jeremy Orlow <jorlow at chromium.org>  2010-05-21 07:00:56 PST ---
(From update of attachment 56705)
WebCore/ChangeLog:14
 +          No new tests are possible at this time.
Please explain why.  And promise to land them soon.  :-)

WebCore/dom/DeviceOrientation.cpp:47
 +      UNUSED_PARAM(alpha);
You may need to include wtf/UnusedParam.h

WebKit/chromium/src/WebViewImpl.cpp:264
 +                          0));
I don't know why these are split across multiple lines like this, but it doesn't match WebKit style...so mind putting these all on one line?

WebKit/mac/WebView/WebView.mm:666
 +      _private->page = new Page(new WebChromeClient(self), new WebContextMenuClient(self), new WebEditorClient(self), new WebDragClient(self), new WebInspectorClient(self), new WebPluginHalterClient(self), geolocationControllerClient, deviceOrientationClient);
Where is deviceOrientationClient defined?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.