[Webkit-unassigned] [Bug 39473] [DRT/Chromium] Link resources and load Ahem font for Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39473





--- Comment #6 from Kent Tamura <tkent at chromium.org>  2010-05-21 02:47:01 PST ---
(In reply to comment #5)
> (From update of attachment 56683 [details])
> The Apple win code just uses AddFontResourceEx instead of AddFontMemResourceEx.  I don't have a preference between the two functions, but it might be less code.  Anyway, I think this is fine too.  LGTM with two style nits.

I tried to use AddFontResourceEx(), but it failed on my Vista machine.  I couldn't find the failure reasons and workarounds other than AddFontMemResourceEx().
(AddFontResourceEx() doesn't provide an error code!)

> > +    ::PathRemoveFileSpec(modulePath);
> > +    WCHAR ahemPath[_MAX_PATH];
> > +    struct _stat ahemStat;
> 
> Nit: Drop struct since it's not needed in C++.
> 
> > +    DWORD numFonts = 1;
> > +    HANDLE h = ::AddFontMemResourceEx(fontBuffer, size, 0, &numFonts);
> 
> Nit: handle or fontHandle would be a more descriptive variable name.

I'll fix them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.