[Webkit-unassigned] [Bug 39473] [DRT/Chromium] Link resources and load Ahem font for Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39473





--- Comment #5 from Tony Chang (Google) <tony at chromium.org>  2010-05-21 02:19:02 PST ---
(From update of attachment 56683)
The Apple win code just uses AddFontResourceEx instead of AddFontMemResourceEx.  I don't have a preference between the two functions, but it might be less code.  Anyway, I think this is fine too.  LGTM with two style nits.

> +    ::PathRemoveFileSpec(modulePath);
> +    WCHAR ahemPath[_MAX_PATH];
> +    struct _stat ahemStat;

Nit: Drop struct since it's not needed in C++.

> +    DWORD numFonts = 1;
> +    HANDLE h = ::AddFontMemResourceEx(fontBuffer, size, 0, &numFonts);

Nit: handle or fontHandle would be a more descriptive variable name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.