[Webkit-unassigned] [Bug 39092] Chromium/Mac: Add support for yank (ctrl-y)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39092





--- Comment #5 from Eric Seidel <eric at webkit.org>  2010-05-20 12:31:10 PST ---
Seems the original design for this would have been cleaner with a platform/KillRing.h class.  This is the current hack for other ports:

#if !PLATFORM(MAC)

void Editor::appendToKillRing(const String&)
{
}

void Editor::prependToKillRing(const String&)
{
}

String Editor::yankFromKillRing()
{
    return String();
}

void Editor::startNewKillRingSequence()
{
}

void Editor::setKillRingToYankedState()
{
}

#endif

I think we should put these calls into an object.  We can either make a KillRingNone for other ports, or we can make all the callers check non-zero.  But the Mac and ChromiumMac ports want to return a KillRingMac object.

Does that design sound sane?  You're more versed in this code than I am by now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.