[Webkit-unassigned] [Bug 39092] Chromium/Mac: Add support for yank (ctrl-y)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 20 07:57:24 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39092





--- Comment #4 from Nico Weber <thakis at chromium.org>  2010-05-20 07:57:23 PST ---
We can't use all of EditorMac (we don't want its Editor::newGeneralClipboard(), Editor::showFontPanel(),  Editor::showStylesPanel(), Editor::showColorPanel(), and Editor::paste()), only about 50% of it.

If we want to share the yank stuff, I could
1.) put that into a file that's used by both the mac port and the chromium port on mac. In that case I need to know what directory put the file with the shared parts.

2.) The RenderTheme stuff now uses inheritance. If we wanted to do that here, I'd need to give Editor a static create() method, change all calling sites of Editor::Editor() to use the factory method, and make some functions virtual. Then I'd put EditorChromiumMac and EditorMac directly into editing/, and make EditorMac a subclass of EditorChromiumMac. This feels intrusive to me.

Do you want me to do one of these (or something else)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list