[Webkit-unassigned] [Bug 37602] AppCache Progress Events - need to include additional info per the spec

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37602





--- Comment #7 from Michael Nordman <michaeln at google.com>  2010-05-19 13:10:52 PST ---
915     pair<EntryMap::iterator, bool> result = m_pendingEntries.add(url, type);
916     m_total++;

I think you have to revisit how you're computing m_total. The same url may be listed multiple times in the manifest file in different sections. It only gets added to the m_pendingEntries collection and downloaded once (the return values indicates if the url was already in the collection), but m_total will have been bumped multiple times for such entries.

Also, the update algorithm can be run multiple times over the life of an ApplicationCacheGroup instance. I think you want to reset m_total and m_loaded when a new update is initiated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.