[Webkit-unassigned] [Bug 37602] AppCache Progress Events - need to include additional info per the spec

Wed May 19 12:23:22 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=37602

--- Comment #6 from Michael Nordman <michaeln at google.com>  2010-05-19 12:23:22 PST ---
To get a webkit reviewer to take a look at these changes, you'll want to set the flag on the patch to r?

> I've switched to use loaded/total instead of loadedItems/totalItems in 
> ProgressEvent.  Added a test case, but need more.  Now sending a final
> progress event (loaded == total).

Right... at TPAC I thought it had been decided to move away from the dual-band progress event model for all progress events, and to stick with the simpler loaded vs total model. Where different use cases would overload loaded vs total such that it doesn't necessarily means 'bytes'.

So the switching to use them for our use is good by me.

> I'm going to attempt to patch the Chromium file, if possible.  Late next week.
> Let me know if trying to do this isn't really possible, or kosher; I'd prefer
> to not have to use interim #IFDEF hacks and just make the actual fix.

That would be nice of you. Just be aware that you won't be able to come up with total vs loaded values for chromium w/o actually making changes to chrome (outside of webkit). Maybe have the progress events in the chromium port set lengthComputable to false and total/loaded to zero for the time being.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.