[Webkit-unassigned] [Bug 38783] [chromium] Implement h/w accelerated compositing for LayerChromium layers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38783


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56297|review?                     |review-
               Flag|                            |




--- Comment #10 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-05-18 08:44:31 PST ---
(From update of attachment 56297)
Overall, looks great.  Just a few minor issues:

WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:535
 +      // The position of they layer is the center of quad.
nit: "they layer" -> "the layer" ?

WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:264
 +              // Scrolling works as follows: We render a quad with the current root layer contents
nit: indent by 4 spaces instead of 8.  true, this means the
body is not visually separate from the "|| (scrollDelta..."
bit, but that's what webkit style would have you do.

WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:359
 +      std::map<LayerChromium*, unsigned int>::iterator textureId;
webkit avoids the container classes from STL.  please use HashMap
from WTF instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.