[Webkit-unassigned] [Bug 38783] [chromium] Implement h/w accelerated compositing for LayerChromium layers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38783





--- Comment #9 from Vangelis Kokkevis <vangelis at chromium.org>  2010-05-17 17:50:38 PST ---
(In reply to comment #7)
> A few minor comments.
> 
> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:215
>  +      FloatPoint3D test2 = renderMatrix.mapPoint(FloatPoint3D(0.5, -0.5, 0));
> Test code should be removed.
> 

Done.

> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:155
>  +  static GLuint createLayerTexture()
> Should refactor with createTextureObject().
> 

Done. Removed createTextureObject() as it wasn't getting used.

> 
> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:265
>  +      offset+= 3 * sizeof(GLfloat);
> Need space between offset and += .
> 

Done.

> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:416
>  +      FloatPoint3D test2 = renderMatrix.mapPoint(FloatPoint3D(0.5, -0.5, 0));
> More test code.
> 

Removed.

> 
> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:720
>  +  }
> Formatting.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.