[Webkit-unassigned] [Bug 37945] CMake buildsystem

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 14 14:46:46 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37945





--- Comment #42 from Adam Treat <treat at kde.org>  2010-05-14 14:46:45 PST ---
(In reply to comment #41)
> (From update of attachment 56111 [details])
> Overall, I like this version much much better and think it is a good first step for a cmake buildsystem that can grow to include more ports.  My other big style nitpick is the choice of UPPERCASE vs lowercase, but I'm not willing to r- on this account alone as lots of cmake buildsystems have this.

When landing you need to be sure to check the buildbots to make sure of no unintended problems with other ports.  Thank you!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list