[Webkit-unassigned] [Bug 37945] CMake buildsystem

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 14 14:45:59 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37945


Adam Treat <treat at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56111|review?                     |review+
               Flag|                            |




--- Comment #41 from Adam Treat <treat at kde.org>  2010-05-14 14:45:59 PST ---
(From update of attachment 56111)
Overall, I like this version much much better and think it is a good first step for a cmake buildsystem that can grow to include more ports.  My other big style nitpick is the choice of UPPERCASE vs lowercase, but I'm not willing to r- on this account alone as lots of cmake buildsystems have this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list