[Webkit-unassigned] [Bug 37945] CMake buildsystem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37945





--- Comment #34 from Gustavo Sverzut Barbieri <barbieri at profusion.mobi>  2010-05-13 12:04:11 PST ---
(In reply to comment #33)
> (In reply to comment #32)
> > I don't want to see cross-platform CMakeLists.txt doing this:
> > 
> > (pseudo)
> > if (port)
> >   include unicodeicu.cpp
> > else
> >   include unicodefoo.cpp
> 
> I think that this should go into the platform specific file.
> I'm not sure if we realy create a own file for this 4 lines.
> I don't see many places where to use this.
> 
> An other question:
> For example we can dedect if the system has sqlite. This will be done with a FindSQLite in the root CMakeLists.txt. If SQLITE_FOUND is set the ENABLE_DATABES will be set. In the WebCore/CMakeLists.txt is then a IF(ENABLE_DATABSE) which add the required source files and libraries for the linker. Do you agree?

Patrick, Please let's not go this route. It is called "automagic" to automatically enable or disable features based on the installed libraries. If we do this, we still need to have explicit/forceful disable/enable that will check the library and emit error messages. If we don't do this, systems that build packages without a clean tree (many cases, like Gentoo users) the packaging system will not know features were enabled and thus the package have dependencies!  To add both automatic and manual, it starts to be a real PITA as many features have multiple dependencies and code start to be messy (I'm saying because I had to care about it for EFL and Gentoo packages, it was troublesome).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.