[Webkit-unassigned] [Bug 37945] CMake buildsystem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37945





--- Comment #33 from Patrick R. Gansterer <paroga at paroga.com>  2010-05-13 11:45:04 PST ---
(In reply to comment #32)
> I don't want to see cross-platform CMakeLists.txt doing this:
> 
> (pseudo)
> if (port)
>   include unicodeicu.cpp
> else
>   include unicodefoo.cpp

I think that this should go into the platform specific file.
I'm not sure if we realy create a own file for this 4 lines.
I don't see many places where to use this.

An other question:
For example we can dedect if the system has sqlite. This will be done with a FindSQLite in the root CMakeLists.txt. If SQLITE_FOUND is set the ENABLE_DATABES will be set. In the WebCore/CMakeLists.txt is then a IF(ENABLE_DATABSE) which add the required source files and libraries for the linker. Do you agree?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.