[Webkit-unassigned] [Bug 37945] CMake buildsystem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37945





--- Comment #30 from Gustavo Sverzut Barbieri <barbieri at profusion.mobi>  2010-05-13 11:09:30 PST ---
Guys, we partially agree with you, but it's hard to say someone is 100% right in this case. Some remarks on our side:

  - CMakeLists.txt including the ${PORT} version is easier and for this case clearer. It is not usual in programming, particular in inheritance, but in this case it does make sense as you can just add the sub directory and CMake will always look for CMakeLists.txt there, not CMakeList${PORT}.txt, then to solve this we add include and it will add directory... which is not that usual. So we're with Patrick here.

  - JIT's CPU detection in general CMakeLists.txt does make sense, at least so far. So with Patrick here as well.

  - DerivedSources does not exist in source, just in build tree, so no option to ADD_DIRECTORY(). If you mean to have it in root or inside cmake/, then I disagree as it will be confusing. So we'd rather stay with these port-independent CMakeList.txt

  - FeatureFOO.cmake is doubtful, as usually the shared bit is a single CPP definition. The dependencies will likely differ a lot, some will not even have dependencies and it is just a feature to reduce code size.  Leandro's WEBKIT_FEATURE() handles that nicely, ports can define it. If you want we could add more logic there to allow ports to define the ${DEFAULT_${FEATURE}} and maybe add a keyword to block it, in this case WEBKIT_FEATURE() could be moved to common files, with these values being defined in the port -- but we rather keep with the simpler yet efficient solution by Leandro.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.