[Webkit-unassigned] [Bug 37945] CMake buildsystem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37945





--- Comment #29 from Adam Treat <treat at kde.org>  2010-05-13 09:31:53 PST ---
(In reply to comment #28)
> (In reply to comment #27)
> > Alright, but the cross-platform ones should be limited to including the port specific files... all other port specific logic should be removed from the cross-platform ones IMO.
> The plaform independent files go into the CMakeLists.txt?
> - CMakeLists.txt: Declares all cross-platform source files, include DerivedSources.cmake and include Port${PORT}.cmake
> - DerivedSources.cmake: Do the code generator stuff.
> - PortGtk.cmake, PortQt.cmake, PortEfl.cmake: Add additional source files and required libs for the target.
> 
> In the JavaScriptCore we need a CPU dedection for the JIT: I think this can go into the CMakeLists.txt because it is not _port_ specific?

Close, but we'll also need FeatureFOO.cmake for features that are shared by more than one port, but not by *all* ports and then the PortFoo.cmake can determine which FeatureFOO.cmake(s) to include.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.