[Webkit-unassigned] [Bug 38846] Merge some pseudo-valid-*.html tests into one

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 10 22:57:00 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38846





--- Comment #5 from Kent Tamura <tkent at chromium.org>  2010-05-10 22:56:59 PST ---
Thank you for reviewing!

(In reply to comment #4)
> (From update of attachment 55556 [details])
> > +var notValidColor = "rgb(0, 255, 0)";
> > +for (var i = 0; i < names.length; i++)
> > +    shouldBe("getBackgroundColor('" + names[i] + "')", "notValidColor");
> 
> I slightly prefer rgb(0, 255, 0) to notValidColor because "foobar is not valid color" sounds like this test is failing.

I see.  It might be confusing.  ok, I'll change notValidColor before landing this.

>     shouldBe("getBackgroundColor('" + names[i] + "')", "rgb(0, 255, 0)");
> 
> Also, I think the color should be not valid nor invalid, right?

You're right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list