[Webkit-unassigned] [Bug 38846] Merge some pseudo-valid-*.html tests into one

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38846


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55556|review?                     |review+
               Flag|                            |




--- Comment #4 from Shinichiro Hamaji <hamaji at chromium.org>  2010-05-10 22:49:01 PST ---
(From update of attachment 55556)
> +var notValidColor = "rgb(0, 255, 0)";
> +for (var i = 0; i < names.length; i++)
> +    shouldBe("getBackgroundColor('" + names[i] + "')", "notValidColor");

I slightly prefer rgb(0, 255, 0) to notValidColor because "foobar is not valid color" sounds like this test is failing.

    shouldBe("getBackgroundColor('" + names[i] + "')", "rgb(0, 255, 0)");

Also, I think the color should be not valid nor invalid, right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.