[Webkit-unassigned] [Bug 38683] SVG FilterEffects need more detailed DRT information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38683





--- Comment #9 from Nikolas Zimmermann <zimmermann at kde.org>  2010-05-08 00:29:40 PST ---
(From update of attachment 55462)
Oops, I hit submit, instead of add, the review continues:

WebCore/svg/graphics/filters/SVGFEMerge.cpp:99
 +              (*it).get()->externalRepresentation(ts, indent + 1);
No need for the .get(), remove it.


WebCore/svg/graphics/filters/SVGFETile.cpp:94
 +      FilterEffect::externalRepresentation(ts);
Same here "[feTile ]" is not nice. :( Maybe just leave out the trailing space
behind "feTile" for now here...

LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:10
 +              [SourceGraphic ]
That's what I meant before, this is not nice - should be fixed if you apply all
comments.

LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:13
 +              [feImage ]
Ditto.

LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:15
 +                  {red:   type="IDENTITY" slope="1.00" intercept="0.00"
amplitude="1.00" exponent="1.00" offset="0.00"}
No need to line up red / green / alpha, etc. The other fields don't have fixed
width, so I'd just leave out the padding.

LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:8
 +            [feMerge ]
Did I forget to mention feMerge before? Also looks not nice :-) Can you fix the
trailing space.

Ok enough for now, will review the results in detail after you've provided new
baselines :-)
A general note on externalRepresentation in the headers: can you add virtual
prefixes everywhere? After all it's defined in the FilterEffect baseclass?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.