[Webkit-unassigned] [Bug 38683] SVG FilterEffects need more detailed DRT information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38683





--- Comment #8 from Nikolas Zimmermann <zimmermann at kde.org>  2010-05-08 00:23:49 PST ---
(From update of attachment 55462)
Next round of review...

WebCore/platform/graphics/filters/FEBlend.cpp:148
 +  static TextStream& operator<<(TextStream& ts, BlendModeType t)
Rename 't' to 'type', no abbrevations. Use a const-reference to BlendModeType
for consistency.

WebCore/platform/graphics/filters/FEColorMatrix.cpp:198
 +  static TextStream& operator<<(TextStream& ts, ColorMatrixType t)
Ditto.

WebCore/platform/graphics/filters/FEColorMatrix.cpp:226
 +      if (!m_values.isEmpty()) {
I'd say it's fine to have _no_ inline helper function here, it's pretty small
and not used anywhere else.

WebCore/platform/graphics/filters/FEColorMatrix.h:54
 +          TextStream& externalRepresentation(TextStream& ts, int indent)
const;
Omit the 'ts'.

WebCore/platform/graphics/filters/FEComponentTransfer.cpp:188
 +  static TextStream& operator<<(TextStream& ts, const ComponentTransferType&
t)
Rename 't' to 'type'.

WebCore/platform/graphics/filters/FEComposite.cpp:176
 +  static TextStream& operator<<(TextStream& ts, CompositeOperationType t)
Rename 't' to 'type' and use a const-reference.

WebCore/platform/graphics/filters/SourceAlpha.cpp:80
 +      ts << "[SourceAlpha ";
As FilterEffect::externalRepresentation dumps nothing, this will result in
"[SourceAlpha ]" - this is a bit unfortunate :(
If FilterEffect should dump subregions in future, you should not need to call
it at all here? just dump ts << "[SourceAlpha]";

WebCore/rendering/RenderTreeAsText.h:50
 +  void writeIndent(TextStream& ts, int indent);
Omit the ' ts'.

WebCore/svg/graphics/filters/SVGFEImage.cpp:74
 +      ts << "]\n";
Can you at least dump the image size here? I don't like "[feImage ]".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.