[Webkit-unassigned] [Bug 38718] test-webkitpy fails under cygwin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38718





--- Comment #17 from Eric Seidel <eric at webkit.org>  2010-05-07 18:35:16 PST ---
(In reply to comment #16)
> (From update of attachment 55393 [details])
> WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:301
>  +      # Easy override for unit tests
> Did you intend to write tests here? If not, I don't see the benefit of having
> this in a separate method.

It's used by every unit test. :)

        port._open_configuration_file = lambda:
WithAwareStringIO(file_contents)


> WebKitTools/Scripts/webkitpy/layout_tests/port/win.py:51
>  +              self._webkit_baseline_path("mac-snowleopard"),
> It's weird that the win port checks mac-snowleopard but not
> mac-leopard/mac-tiger. I'd expect all of those or none of them. Anyways, this
> does match old-run-webkit tests. For consistency, do you mind making the same
> change to port/chromium_win.py? Or just file a bug. It's missing this one line.

OK, I can add a FIXME.  I don't dare change chromium_win, as it might cause all
sorts of failures with different fallback results.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.