[Webkit-unassigned] [Bug 38718] test-webkitpy fails under cygwin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 7 10:36:01 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38718





--- Comment #16 from Ojan Vafai <ojan at chromium.org>  2010-05-07 10:35:59 PST ---
(From update of attachment 55393)
WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:301
 +      # Easy override for unit tests
Did you intend to write tests here? If not, I don't see the benefit of having
this in a separate method.

WebKitTools/Scripts/webkitpy/layout_tests/port/win.py:51
 +              self._webkit_baseline_path("mac-snowleopard"),
It's weird that the win port checks mac-snowleopard but not
mac-leopard/mac-tiger. I'd expect all of those or none of them. Anyways, this
does match old-run-webkit tests. For consistency, do you mind making the same
change to port/chromium_win.py? Or just file a bug. It's missing this one line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list