[Webkit-unassigned] [Bug 38213] Page up / page down moves edited content for the entire height

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38213





--- Comment #21 from Ojan Vafai <ojan at chromium.org>  2010-05-07 17:16:47 PST ---
(From update of attachment 55433)
WebCore/editing/SelectionController.cpp:168
 +          if (m_frame->settings()->editingBehavior() == EditingMacBehavior)
You should use the settings pointer you got in line 165. Also, you need to
nullcheck settings here.

WebCore/editing/EditorCommand.cpp:262
 +      int height = frame->view()->visibleHeight();
This doesn't look right to me. We're scrolling a renderer here that has
overflow (i.e. the scrollbars are on that box, not the frame). Can you maybe
add a case to your test (or another test) where you test scrolling in a div
with overflow:auto?

WebCore/editing/EditorCommand.cpp:260
 +      if (!(style->overflowY() == OSCROLL || style->overflowY() == OAUTO ||
focusedNode->isContentEditable()))
This is only tangentially related to your code, so feel free to ignore, but
this if-statement doesn't look right to me. If we're in a contentEditable
element that's overflow:visible, I think we probably want to early return here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.