[Webkit-unassigned] [Bug 38213] Page up / page down moves edited content for the entire height

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38213


Zelidrag Hornung <zelidrag at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54949|0                           |1
        is obsolete|                            |
  Attachment #55433|                            |review?, commit-queue?
               Flag|                            |




--- Comment #20 from Zelidrag Hornung <zelidrag at chromium.org>  2010-05-07 16:50:06 PST ---
Created an attachment (id=55433)
 --> (https://bugs.webkit.org/attachment.cgi?id=55433)
Addressed the latest set of comments

Please note that test scroll-viewport-page-up-down.html covers platform
differences in scroll view between mac and other platforms while
option-page-up-down.html actually ensures that the cursor it on the same line
on page up/down event regardless of the platform. 

* (re)added somehow dropped per-function comments into ChangeLog
* renames SelectionController::CursorAlignOnScroll enum and its values to give
more details about what they do
* removed #include "RenderBox.h" from WebCore/editing/EditorCommand.cpp
* renames cursorAlignment param
* changed #if OS(DARWIN) to settings->editingBehavior() == EditingMacBehavior
in SelectionController.cpp

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.