[Webkit-unassigned] [Bug 38749] [Chromium] Pipe RTL info into WebPopupMenuInfo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38749


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55374|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #5 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-05-07 11:30:12 PST ---
(From update of attachment 55374)
WebKit/chromium/public/WebPopupMenuInfo.h:47
 +      bool rightAligned;
Use the WebTextDirection enum here?

WebKit/chromium/src/ChromeClientImpl.cpp:694
 +      info->rightAligned = popupClient->menuStyle().textDirection() == RTL;
Why not just get the PopupMenuStyle object from the PopupContainer?
You could add a method on PopupContainer that returns PopupMenuStyle*.
It doesn't seem necessary to plumb PopupMenuClient* through the layers
when you have PopupContainer at your disposal.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.