[Webkit-unassigned] [Bug 38749] [Chromium] Pipe RTL info into WebPopupMenuInfo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38749


Xiaomei Ji <xji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xji at chromium.org




--- Comment #6 from Xiaomei Ji <xji at chromium.org>  2010-05-07 16:02:04 PST ---
(In reply to comment #2)
> (From update of attachment 55374 [details])
> Ob-Disclaimer: I'm not a WebKit reviewer.
> 
> WebKit/chromium/src/ChromeClientImpl.cpp:694
>  +      info->rightAligned = popupClient->menuStyle().textDirection() == RTL;
> It's not really text alignment, but directionality - IMHO rename to rtl,
> directionality [and use an enum] or somesuch.
> 
> Otherwise, lgtm.

We are currently using popup's text direction to direct the alignment (align
right if the <select> is RTL, align right if the <input> is RTL).

Webkit always align popup left (at least in Mac, when writing direction is
natural) in RenderMenuList::adjustInnerStyle() (refer to Bug 19785).

We need to add text alignment in PopupMenuStyle, so that we can display the
text in <select> box using natural writing direction, and draw the texts in
popup box in desired alignment.

I am opening another Bug 38780

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.