[Webkit-unassigned] [Bug 36291] placeholder text should be stripped from line breaks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36291





--- Comment #6 from Kent Tamura <tkent at chromium.org>  2010-05-07 10:18:38 PST ---
(In reply to comment #5)
> > > +        ASSERT(node()->isHTMLElement());
> > 
> > This is not the right assertion. You need to assert this is an HTMLInputElement
> > since that's what you are casting to.
> 
> No.
>  - WMLInputElement also has inputTag.
>  - HTMLInputElement represents <isindex> too, and we support placeholder for it
> (See LayoutTests/fast/forms/isindex-placeholder.html)

I meant "No" for ASSERT(node()->hasTagName(inputTag)).
I don't think ASSERT(hasTagName(inputTag) || hasTagName(isindexTag)) should be
added to  here because we assume isHTMLElement() == HTMLInputElement in
RenderTextControlSingleLine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.