[Webkit-unassigned] [Bug 36291] placeholder text should be stripped from line breaks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 7 18:10:24 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36291





--- Comment #7 from Darin Adler <darin at apple.com>  2010-05-07 18:10:23 PST ---
(In reply to comment #6)
> >  - WMLInputElement also has inputTag.

That's WMLNames::inputTag, which is not the same as HTMLNames::inputTag.

> >  - HTMLInputElement represents <isindex> too, and we support placeholder for it

Good point.

> we assume isHTMLElement() == HTMLInputElement in RenderTextControlSingleLine.

OK.

But generally speaking if we're about to typecast something, we want an
assertion to state that the typecast is OK. And isHTMLElement() does not check
that for HTMLInputElement*!

ValidityState::typeMismatch is one of many places that uses
hasTagName(inputTag) as a guard for a cast to HTMLInputElement*. It's almost
certainly OK that site returns false for <isindex>, though, so it's probably
OK.

Maybe we need to put an isHTMLInputElement function somewhere so we can use it
in this assertion. We might also want to audit all the call sites checking
inputTag to see if any of them need to cover isindexTag too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list