[Webkit-unassigned] [Bug 38445] REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 2 21:20:56 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38445





--- Comment #3 from mitz at webkit.org  2010-05-02 21:20:56 PST ---
(In reply to comment #2)
> > +static Position downstreamIgnoringEditingBoundaries(Position position)
> 
> Should this take a const Position&?

It’d have to be copied anyway, and this was easier to write.

>  +          test for buttons with the generic and more comprehensive
> canHaveChildrenForEditing().
> 
> Does this part of the change need its own testcase?

Existing tests crash without it.

Thanks for the review!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list