[Webkit-unassigned] [Bug 38445] REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset()

Sun May 2 21:13:33 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=38445

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54901|review?                     |review+
               Flag|                            |

--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com>  2010-05-02 21:13:33 PST ---
(From update of attachment 54901)
> Index: WebCore/ChangeLog
> ===================================================================

> +        possible, crossing any editability boudaries. Infinite recursion is avoided by advancing all the way

Typo: "boudaries"

> Index: WebCore/dom/Position.cpp
> ===================================================================

> +static Position downstreamIgnoringEditingBoundaries(Position position)

Should this take a const Position&?

> +static Position upstreamIgnoringEditingBoundaries(Position position)

Ditto

WebCore/ChangeLog:18
 +          test for buttons with the generic and more comprehensive
canHaveChildrenForEditing().

Does this part of the change need its own testcase?

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.