[Webkit-unassigned] [Bug 35760] [Chromium] Adding Chromium -> WebCore touch type conversions
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 4 14:22:42 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=35760
--- Comment #3 from Garret Kelly (Google) <gdk at chromium.org> 2010-03-04 14:22:42 PST ---
(In reply to comment #2)
> (From update of attachment 50043 [details])
> Aren't PlatformTouchEvent used as stack objects? They're not ref-counted, so I
> assume no one holds pointers to them. In that case, virtual methods (like
> virtual destructors) make no sense!
Fair enough. I'll remove the virtual destructors.
> This seems like the wrong model. Normally Platform*Event classes are passed a
> WebKit-layer class pointer and they convert that. This seems to be going the
> opposite way for reasons I dont' understand.
In Chromium, WebInputEvents (the Chromium layer types) are converted to their
WebKit-layer counterparts by subclassing them and handling the conversion in
their constructors (The Platform*Builder classes). This logic lives in
WebKit/WebKit/chromium/src/WebInputEventConversion.cpp.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list