[Webkit-unassigned] [Bug 35760] [Chromium] Adding Chromium -> WebCore touch type conversions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 4 14:00:35 PST 2010


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #50043|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #2 from Eric Seidel <eric at webkit.org>  2010-03-04 14:00:35 PST ---
(From update of attachment 50043)
Aren't PlatformTouchEvent used as stack objects?  They're not ref-counted, so I
assume no one holds pointers to them.  In that case, virtual methods (like
virtual destructors) make no sense!

This seems like the wrong model.  Normally Platform*Event classes are passed a
WebKit-layer class pointer and they convert that.  This seems to be going the
opposite way for reasons I dont' understand.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list