[Webkit-unassigned] [Bug 34347] MathML Support for mrow and Stretchy Operators
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 4 04:40:37 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=34347
Kenneth Rohde Christiansen <kenneth at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49928|review? |review-
Flag| |
--- Comment #9 from Kenneth Rohde Christiansen <kenneth at webkit.org> 2010-03-04 04:40:36 PST ---
(From update of attachment 49928)
Looks better but still some issues :-) r- because of inconsistency with
variable/comment
129 Element* mo = 0;
130 if (node()->nodeType() == Node::ELEMENT_NODE) {
131 mo = static_cast<Element*>(node());
132 if (mo) {
You don't seem to use mo outside, so you could do
if (Element* mo = static_cast<Element*>(node())) {
...
}
150 // canStretch indicates whether the character is streatchable via a
number of factors.
151 bool isStretchy = false;
Please fix the comment or variable.
195
196 } else {
unneeded newline
260 }
261
262 }
same thing
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list