[Webkit-unassigned] [Bug 34347] MathML Support for mrow and Stretchy Operators

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 4 06:41:51 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34347





--- Comment #10 from Alex Milowski <alex at milowski.com>  2010-03-04 06:41:51 PST ---
(In reply to comment #9)
> (From update of attachment 49928 [details])
> Looks better but still some issues :-) r- because of inconsistency with
> variable/comment
> 
> 129     Element* mo = 0;
> 130     if (node()->nodeType() == Node::ELEMENT_NODE) {
> 131         mo = static_cast<Element*>(node());
> 132         if (mo) {
> 
> You don't seem to use mo outside, so you could do

I actually is used later on in one case.  Maybe I'll just get it again because
it seems easy to miss.

Newlines are obviously a habit that is hard to break.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list