[Webkit-unassigned] [Bug 35146] [Qt] Support tiled backing store

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35146





--- Comment #19 from Xan Lopez <xan.lopez at gmail.com>  2010-03-03 07:28:55 PST ---
(In reply to comment #18)
> Unnecessary after continue (and against coding style too).

The style guide only mentions return, FWIW, but I guess continue adheres to the
spirit of it.

> 
> > nitpick, but you can just do the for loop and requiredTileCount-- on each
> > iteration.
> 
> Sure but why? It would be slower. Please limit nitpicking to stuff that makes
> sense. :)

The point was that protecting the for loop with an if seems redundant since the
code works exactly the same way without it. I suggested subtracting one on each
iteration to get rid of the variable declaration and avoid the weird looking
requiredTileCount -= tilesToCreateCount; when tilesToCreateCount is 0, and
surely whatever difference in performance is caused by this is totally
irrelevant.

But it was just a detail, so shrug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.